Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickects/PREOPS-4646: Support addition of opsim data to an archive for use by schedview-prenight #60

Merged
merged 16 commits into from
Jan 31, 2024
Merged

tickects/PREOPS-4646: Support addition of opsim data to an archive for use by schedview-prenight #60

merged 16 commits into from
Jan 31, 2024

Conversation

ehneilsen
Copy link
Collaborator

This update to schedview needs to be coordinate with the corresponding branch (with the same name) on rubin_scheduler.

@ehneilsen
Copy link
Collaborator Author

Of course, the tests in the github actions are filing now, because it isn't grabbing the rubin_scheduler version on the needed branch.

rhiannonlynne
rhiannonlynne reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some questions.

docs/installation.rst Show resolved Hide resolved
schedview/app/prenight/prenight.py Outdated Show resolved Hide resolved
schedview/app/prenight/prenight.py Show resolved Hide resolved
schedview/collect/opsim.py Outdated Show resolved Hide resolved
schedview/data/sim_metadata.yaml Show resolved Hide resolved
@ehneilsen
Starting notebook to add achived elements piecemeal
b31c3b4
@ehneilsen
functions to make dir and add it to s3 bucket
b594cee
@ehneilsen
support loading observations from a resource dir
ee602a8
@ehneilsen
in progress adding support to load from archive in dashboard
77d442b
@ehneilsen
switch from using ResourcePath.as_local to avoid threading issues
c72eacc
@ehneilsen
examples of adding opsim data to archive
817d4ed
@ehneilsen
autoload rewards in prenight dashboard
53d6fc1
@ehneilsen
show use of drive_sim to put sims in the archive for schedview
64e4ca9
@ehneilsen
be robust wrt missing rewards in archive
4ae51ec
@ehneilsen
remove no longer helpful log line
9a7d622
@ehneilsen
document use of sim archive in prenight
ce4ad09
@ehneilsen
Remove commented out code
1d9096c
@ehneilsen
clarify rubin vs. non-rubin aspects of s3 bucket access
2f10d8e
@ehneilsen
fix ArchiveInputPrenight docstring
b2704ec
@ehneilsen
use lsst.resource's as_local where possible
3f147e5
@ehneilsen
clear execution
c6e6b31
@ehneilsen ehneilsen merged commit 05615f0 into main Jan 31, 2024
7 checks passed
@ehneilsen ehneilsen deleted the tickects/PREOPS-4646 branch January 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj left review comments

@rhiannonlynne rhiannonlynne rhiannonlynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehneilsen @timj @rhiannonlynne